zeroshade commented on code in PR #43957:
URL: https://github.com/apache/arrow/pull/43957#discussion_r1751077410
##########
cpp/src/arrow/compute/kernels/hash_aggregate.cc:
##########
@@ -892,8 +894,10 @@ struct GroupedVarStdImpl : public GroupedAggregator {
// float/double/int64/decimal: calculate `m2` (sum((X-mean)^2)) with
// `two pass algorithm` (see aggregate_var_std.cc)
template <typename T = Type>
- enable_if_t<is_floating_type<T>::value || (sizeof(CType) > 4), Status>
ConsumeImpl(
- const ExecSpan& batch) {
+ enable_if_t<is_floating_type<T>::value || (sizeof(CType) > 4) ||
+ (!is_integer_type<T>::value && sizeof(CType) == 4),
Review Comment:
fixed to have SumType for Decimal32 be Decimal64 now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
