adamreeve commented on code in PR #6637:
URL: https://github.com/apache/arrow-rs/pull/6637#discussion_r1988070369
##########
parquet/src/arrow/async_reader/mod.rs:
##########
@@ -175,6 +227,15 @@ impl ArrowReaderMetadata {
) -> Result<Self> {
// TODO: this is all rather awkward. It would be nice if
AsyncFileReader::get_metadata
// took an argument to fetch the page indexes.
+ #[cfg(feature = "encryption")]
+ let mut metadata = if options.file_decryption_properties.is_some() {
Review Comment:
Yep that looks good to me thanks, although Andrew's suggested change in
https://github.com/apache/arrow-rs/pull/6637#discussion_r1987945902 would tidy
this up even more and makes a lot of sense to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
