rok commented on code in PR #6637:
URL: https://github.com/apache/arrow-rs/pull/6637#discussion_r1988183461


##########
parquet/src/arrow/async_reader/mod.rs:
##########
@@ -104,6 +107,14 @@ pub trait AsyncFileReader: Send {
     /// allowing fine-grained control over how metadata is sourced, in 
particular allowing
     /// for caching, pre-fetching, catalog metadata, etc...
     fn get_metadata(&mut self) -> BoxFuture<'_, Result<Arc<ParquetMetaData>>>;
+
+    /// Provides asynchronous access to the [`ParquetMetaData`] of encrypted 
parquet
+    /// files, like get_metadata does for unencrypted ones.
+    #[cfg(feature = "encryption")]
+    fn get_metadata_with_encryption(
+        &mut self,
+        file_decryption_properties: Option<FileDecryptionProperties>,

Review Comment:
   That does indeed seem like the better API! Changed in 
https://github.com/apache/arrow-rs/pull/6637/commits/90434d67e4cda052da8b3695da3b539e510e6e3c



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to