adamreeve commented on code in PR #6637:
URL: https://github.com/apache/arrow-rs/pull/6637#discussion_r1988043589
##########
parquet/src/arrow/async_reader/store.rs:
##########
@@ -175,6 +177,24 @@ impl AsyncFileReader for ParquetObjectReader {
Ok(Arc::new(metadata))
})
}
+
+ #[cfg(feature = "encryption")]
+ fn get_metadata_with_encryption(
+ &mut self,
+ _file_decryption_properties: Option<FileDecryptionProperties>,
+ ) -> BoxFuture<'_, Result<Arc<ParquetMetaData>>> {
+ Box::pin(async move {
Review Comment:
It looks like it was passed to the `ParquetMetaDataReader` before but then
this was removed in
https://github.com/apache/arrow-rs/pull/6637/commits/7e9e7aa35c9daf235db652d982e582eb4cb52b2f#diff-35587a1f67c8b7107349a24190ed7ce8e3d8aaa047cd13c50737249155cae551,
why was that @rok?
It would be good to have a test that exercises using encryption with an
ObjectStore if possible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
