rok commented on code in PR #6637:
URL: https://github.com/apache/arrow-rs/pull/6637#discussion_r1988184574
##########
parquet/src/arrow/async_reader/mod.rs:
##########
@@ -853,6 +929,10 @@ struct InMemoryRowGroup<'a> {
offset_index: Option<&'a [OffsetIndexMetaData]>,
column_chunks: Vec<Option<Arc<ColumnChunkData>>>,
row_count: usize,
+ #[cfg(feature = "encryption")]
+ row_group_ordinal: usize,
Review Comment:
Changed to `row_group_idx`.
I don't have a strong preference, but parquet [encryption spec uses
ordinal](https://parquet.apache.org/docs/file-format/data-pages/encryption/)
while here we do indeed use idx.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
