rok commented on code in PR #6637: URL: https://github.com/apache/arrow-rs/pull/6637#discussion_r1988187769
########## parquet/src/encryption/decrypt.rs: ########## @@ -0,0 +1,260 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +use crate::encryption::ciphers::{BlockDecryptor, RingGcmBlockDecryptor}; +use crate::encryption::modules::{create_module_aad, ModuleType}; +use crate::errors::{ParquetError, Result}; +use std::collections::HashMap; +use std::io::Read; +use std::sync::Arc; + +pub fn read_and_decrypt<T: Read>( + decryptor: &Arc<dyn BlockDecryptor>, + input: &mut T, + aad: &[u8], +) -> Result<Vec<u8>> { + let mut len_bytes = [0; 4]; + input.read_exact(&mut len_bytes)?; + let ciphertext_len = u32::from_le_bytes(len_bytes) as usize; + let mut ciphertext = vec![0; 4 + ciphertext_len]; + input.read_exact(&mut ciphertext[4..])?; + + decryptor.decrypt(&ciphertext, aad.as_ref()) +} + +// CryptoContext is a data structure that holds the context required to +// decrypt parquet modules (data pages, dictionary pages, etc.). +#[derive(Debug, Clone)] +pub(crate) struct CryptoContext { + pub(crate) row_group_ordinal: usize, Review Comment: See https://github.com/apache/arrow-rs/pull/6637#discussion_r1988184574. I'm ok with changing page_ordinal and column_ordinal if you think it's better for readability. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
