amoeba commented on code in PR #46180:
URL: https://github.com/apache/arrow/pull/46180#discussion_r2053095188
##########
cpp/src/arrow/util/from_json_test.cc:
##########
@@ -916,7 +914,8 @@ TEST(TestMap, IntegerMapToStringList) {
auto& key_key_builder =
checked_cast<Int16Builder&>(*key_builder.key_builder());
auto& key_item_builder =
checked_cast<Int16Builder&>(*key_builder.item_builder());
auto& item_builder = checked_cast<ListBuilder&>(*map_builder.item_builder());
- auto& item_value_builder =
checked_cast<StringBuilder&>(*item_builder.value_builder());
+ auto& item_value_builder =
+ checked_cast<class StringBuilder&>(*item_builder.value_builder());
Review Comment:
clangd helps explain this here:
```
Must use 'class' tag to refer to type 'StringBuilder' in this scope (fix
available)clang(use_of_tag_name_without_tag)
string_builder.h(65, 13): Class 'StringBuilder' is hidden by a non-type
declaration of 'StringBuilder' here
```
I think by changing the namespace from arrow::ipc::internal to arrow::util
causes a collision with
https://github.com/apache/arrow/blob/75acf37683cc32556fbea00771e66eae8af73a42/cpp/src/arrow/util/string_builder.h#L65
so adding `class` helps disambiguate. Is there a better way maybe?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
