amoeba commented on code in PR #46180:
URL: https://github.com/apache/arrow/pull/46180#discussion_r2053089215
##########
cpp/src/arrow/util/from_json_test.cc:
##########
@@ -916,7 +914,8 @@ TEST(TestMap, IntegerMapToStringList) {
auto& key_key_builder =
checked_cast<Int16Builder&>(*key_builder.key_builder());
auto& key_item_builder =
checked_cast<Int16Builder&>(*key_builder.item_builder());
auto& item_builder = checked_cast<ListBuilder&>(*map_builder.item_builder());
- auto& item_value_builder =
checked_cast<StringBuilder&>(*item_builder.value_builder());
+ auto& item_value_builder =
+ checked_cast<class StringBuilder&>(*item_builder.value_builder());
Review Comment:
I got this to fail locally, I wonder if this is a thing with newer clang?
```
/Library/Developer/CommandLineTools/usr/bin/c++ -DARROW_EXTRA_ERROR_CONTEXT
-DARROW_HAVE_NEON -DARROW_WITH_TIMING_TESTS
-I/Users/bryce/src/apache/arrow/cpp/build/src
-I/Users/bryce/src/apache/arrow/cpp/src
-I/Users/bryce/src/apache/arrow/cpp/src/generated -isystem
/Users/bryce/src/apache/arrow/cpp/build/_deps/googletest-src/googlemock/include
-isystem
/Users/bryce/src/apache/arrow/cpp/build/_deps/googletest-src/googletest/include
-isystem /Users/bryce/src/apache/arrow/cpp/thirdparty/flatbuffers/include
-isystem
/Users/bryce/src/apache/arrow/cpp/build/_deps/googletest-src/googletest
-isystem
/Users/bryce/src/apache/arrow/cpp/build/_deps/googletest-src/googlemock
-fno-aligned-new -Qunused-arguments -fcolor-diagnostics -Wall -Wextra
-Wdocumentation -DARROW_WARN_DOCUMENTATION -Wshorten-64-to-32
-Wno-missing-braces -Wno-unused-parameter -Wno-constant-logical-operand
-Wno-return-stack-address -Wdate-time -Wno-unknown-warning-option
-Wno-pass-failed -march=armv8-a -g -Werror -O0 -ggdb
-std=c++17 -arch arm64 -isysroot
/Library/Developer/CommandLineTools/SDKs/MacOSX15.4.sdk -fPIE -MD -MT
src/arrow/util/CMakeFiles/arrow-from-json-test.dir/from_json_test.cc.o -MF
src/arrow/util/CMakeFiles/arrow-from-json-test.dir/from_json_test.cc.o.d -o
src/arrow/util/CMakeFiles/arrow-from-json-test.dir/from_json_test.cc.o -c
/Users/bryce/src/apache/arrow/cpp/src/arrow/util/from_json_test.cc
/Users/bryce/src/apache/arrow/cpp/src/arrow/util/from_json_test.cc:918:20:
error: must use 'class' tag to refer to type 'StringBuilder' in this scope
918 | checked_cast<StringBuilder&>(*item_builder.value_builder());
| ^
| class
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
