amoeba commented on code in PR #46180:
URL: https://github.com/apache/arrow/pull/46180#discussion_r2053087900
##########
cpp/src/arrow/c/bridge_test.cc:
##########
@@ -1004,15 +1006,16 @@ TEST_F(TestArrayExport, List) {
TEST_F(TestArrayExport, ListSliced) {
{
auto factory = []() {
- return ArrayFromJSON(list(int8()), "[[1, 2], [3, null], [4, 5, 6],
null]")
+ return arrow::ArrayFromJSON(list(int8()), "[[1, 2], [3, null], [4, 5,
6], null]")
Review Comment:
Hrm, not totally sure what's best here. In this PR, I included `from_json.h`
in `api.h` which has a few consequences related to your comment here. I don't
think we strictly need to put things in api.h so I'm going to back that out and
clean things up.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
