lidavidm commented on code in PR #2740: URL: https://github.com/apache/arrow-adbc/pull/2740#discussion_r2057046862
########## c/include/arrow-adbc/adbc.h: ########## @@ -280,7 +284,7 @@ typedef uint8_t AdbcStatusCode; /// ADBC_ERROR_VENDOR_CODE_PRIVATE_DATA. Clients are required to initialize /// this struct to avoid the possibility of uninitialized values confusing the /// driver. -struct ADBC_EXPORT AdbcError { +struct AdbcError { Review Comment: I'm fairly sure we need them for Windows. Should they just be no-op'd on Linux? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org