WillAyd commented on code in PR #2740:
URL: https://github.com/apache/arrow-adbc/pull/2740#discussion_r2059171645
##########
c/include/arrow-adbc/adbc.h:
##########
@@ -152,15 +152,19 @@ struct ArrowArrayStream {
// Storage class macros for Windows
// Allow overriding/aliasing with application-defined macros
#if !defined(ADBC_EXPORT)
-#if defined(_WIN32)
+#if (defined(_WIN32) || defined(__CYGWIN__)) && defined(ADBC_BUILD_DLL)
Review Comment:
While this is consistent with nanoarrow, I do wonder if requiring two
defines (ADBC_EXPORTING and ADBC_BUILD_DLL) is superfluous; the latter prevents
the former from having any meaning when applied to a static library, but maybe
it would be easier to just ensure ADBC_EXPORTING is never defined for static
targets (?)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
