WillAyd commented on PR #2740: URL: https://github.com/apache/arrow-adbc/pull/2740#issuecomment-2833481994
> In general, we should use separated `XXX_EXPORT` macro for each DLL. For example, we should use `ADBC_MANAGER_EXPORT` for `adbc_driver_manager.dll` and `ADBC_POSTGRESQL_EXPORT` for `adbc_driver_postgresql.dll`. If we use `ADBC_EXPORT` for all `.dll`s, we can't mix static `adbc_driver_manager.lib` and shared `adbc_driver_postgresql.dll`. This is a good idea - OK to do as a follow up? I think that will be a larger change > Could you also update `.pc`? We need to specify `ADBC_BUILD_DLL` for shared linking, right? (We can use `pkgconf --static` and `Cflags.private` for static linking only flags but how to do it for shared linking only flags...?) I think if we switch over to your idea for defining a macro when statically linking instead of shared linking then that will help simplify this for Unix platforms. I am not sure about Windows platforms - is there a way within pkg-config to specify that certain defines are only valid for static linkage? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
