paleolimbot commented on code in PR #2740:
URL: https://github.com/apache/arrow-adbc/pull/2740#discussion_r2057418800


##########
c/include/arrow-adbc/adbc.h:
##########
@@ -280,7 +284,7 @@ typedef uint8_t AdbcStatusCode;
 /// ADBC_ERROR_VENDOR_CODE_PRIVATE_DATA.  Clients are required to initialize
 /// this struct to avoid the possibility of uninitialized values confusing the
 /// driver.
-struct ADBC_EXPORT AdbcError {
+struct AdbcError {

Review Comment:
   Our C structs should almost certainly not need them (I believe it would only 
apply to a struct with methods/constructor/destructor?)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to