kou commented on PR #2740: URL: https://github.com/apache/arrow-adbc/pull/2740#issuecomment-2834603029
> This is a good idea - OK to do as a follow up? I think that will be a larger change I'm OK with it. Or it may be better that we split this PR to per driver PRs. Each PR will add separated `ADBC_XXX_EXPORT`. > I think if we switch over to your idea for defining a macro when statically linking instead of shared linking then that will help simplify this for Unix platforms. I am not sure about Windows platforms - is there a way within pkg-config to specify that certain defines are only valid for static linkage? We can use the same approach (`Cflags.private`) with pkg-config on Windows (MSYS2). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
