kou commented on code in PR #46509:
URL: https://github.com/apache/arrow/pull/46509#discussion_r2101532932
##########
cpp/cmake_modules/ThirdpartyToolchain.cmake:
##########
@@ -4845,6 +4845,15 @@ macro(build_opentelemetry)
version)
set(OPENTELEMETRY_BUILD_BYPRODUCTS)
set(OPENTELEMETRY_LIBRARIES)
+ set(OPENTELEMETRY_CXX_FLAGS "${EP_CXX_FLAGS}")
+ # GH-46508: Supress warnings that won't be demoted by -Wno-error in recent
Clang.
+ if((CMAKE_CXX_COMPILER_ID STREQUAL "Clang" AND CMAKE_CXX_COMPILER_VERSION
+ VERSION_GREATER_EQUAL
"19.1.0")
+ OR (CMAKE_CXX_COMPILER_ID STREQUAL "AppleClang" AND
CMAKE_CXX_COMPILER_VERSION
+ VERSION_GREATER_EQUAL
"17.0.0"))
+ string(APPEND OPENTELEMETRY_CXX_FLAGS
+ " -Wno-error=missing-template-arg-list-after-template-kw")
Review Comment:
> For TSAN I'm not sure if this is the case. I did debug a bit today but
still no clue. It's much more difficult than I expected.
How about asking OpenTelemetry C++ developers at
https://github.com/open-telemetry/opentelemetry-cpp/discussions ?
> Plus we have new emerging ASAN errors after suppressing the leak error.
https://github.com/apache/arrow/actions/runs/15152202496/job/42600231311?pr=46509#step:7:4072
```text
==16624==ERROR: AddressSanitizer: heap-use-after-free on address
0x604000010a18 at pc 0x556f354d1d0f bp 0x7fff3cb44c80 sp 0x7fff3cb44c78
WRITE of size 4 at 0x604000010a18 thread T0
#0 0x556f354d1d0e in __exchange_and_add
/usr/bin/../lib/gcc/x86_64-linux-gnu/11/../../../../include/c++/11/ext/atomicity.h:66:12
#1 0x556f354d1d0e in __exchange_and_add_dispatch
/usr/bin/../lib/gcc/x86_64-linux-gnu/11/../../../../include/c++/11/ext/atomicity.h:101:14
#2 0x556f354d1d0e in
std::_Sp_counted_base<(__gnu_cxx::_Lock_policy)2>::_M_release()
/usr/bin/../lib/gcc/x86_64-linux-gnu/11/../../../../include/c++/11/bits/shared_ptr_base.h:165:6
#3 0x556f354d197e in
std::__shared_count<(__gnu_cxx::_Lock_policy)2>::~__shared_count()
/usr/bin/../lib/gcc/x86_64-linux-gnu/11/../../../../include/c++/11/bits/shared_ptr_base.h:705:11
#4 0x556f35500534 in
std::__shared_ptr<opentelemetry::v1::trace::NoopTracer,
(__gnu_cxx::_Lock_policy)2>::~__shared_ptr()
/usr/bin/../lib/gcc/x86_64-linux-gnu/11/../../../../include/c++/11/bits/shared_ptr_base.h:1154:31
#5 0x556f354f84c0 in
std::shared_ptr<opentelemetry::v1::trace::NoopTracer>::~shared_ptr()
/usr/bin/../lib/gcc/x86_64-linux-gnu/11/../../../../include/c++/11/bits/shared_ptr.h:122:11
#6 0x7f9743791a55 in __cxa_finalize
(/lib/x86_64-linux-gnu/libc.so.6+0x45a55) (BuildId:
cd410b710f0f094c6832edd95931006d883af48e)
#7 0x7f974f0a9ac6 in __do_global_dtors_aux crtstuff.c
```
It seems that this is also related to
https://github.com/open-telemetry/opentelemetry-cpp/blob/v1.20.0/sdk/src/trace/tracer.cc#L41-L42
.
I think that we can suppress this too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
