kou commented on code in PR #46509:
URL: https://github.com/apache/arrow/pull/46509#discussion_r2103632654
##########
cpp/cmake_modules/ThirdpartyToolchain.cmake:
##########
@@ -4845,6 +4845,15 @@ macro(build_opentelemetry)
version)
set(OPENTELEMETRY_BUILD_BYPRODUCTS)
set(OPENTELEMETRY_LIBRARIES)
+ set(OPENTELEMETRY_CXX_FLAGS "${EP_CXX_FLAGS}")
+ # GH-46508: Supress warnings that won't be demoted by -Wno-error in recent
Clang.
+ if((CMAKE_CXX_COMPILER_ID STREQUAL "Clang" AND CMAKE_CXX_COMPILER_VERSION
+ VERSION_GREATER_EQUAL
"19.1.0")
+ OR (CMAKE_CXX_COMPILER_ID STREQUAL "AppleClang" AND
CMAKE_CXX_COMPILER_VERSION
+ VERSION_GREATER_EQUAL
"17.0.0"))
+ string(APPEND OPENTELEMETRY_CXX_FLAGS
+ " -Wno-error=missing-template-arg-list-after-template-kw")
Review Comment:
Could you try the following?
Add `suppressions` option for ASAN:
```diff
diff --git a/cpp/build-support/run-test.sh b/cpp/build-support/run-test.sh
index 55e3fe0980..f176586a0f 100755
--- a/cpp/build-support/run-test.sh
+++ b/cpp/build-support/run-test.sh
@@ -75,10 +75,9 @@ function setup_sanitizers() {
UBSAN_OPTIONS="$UBSAN_OPTIONS
suppressions=$ROOT/build-support/ubsan-suppressions.txt"
export UBSAN_OPTIONS
- # Enable leak detection even under LLVM 3.4, where it was disabled by
default.
- # This flag only takes effect when running an ASAN build.
- # ASAN_OPTIONS="$ASAN_OPTIONS detect_leaks=1"
- # export ASAN_OPTIONS
+ # Set up suppressions for AddressSanitizer
+ ASAN_OPTIONS="$ASAN_OPTIONS
suppressions=$ROOT/build-support/asan-suppressions.txt"
+ export ASAN_OPTIONS
# Set up suppressions for LeakSanitizer
LSAN_OPTIONS="$LSAN_OPTIONS
suppressions=$ROOT/build-support/lsan-suppressions.txt"
```
Add `cpp/build-support/asan-suppressions.txt`:
```text
type:opentelemetry::v1::trace::NoopTracer
```
See also: https://clang.llvm.org/docs/AddressSanitizer.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
