zanmato1984 commented on code in PR #46509:
URL: https://github.com/apache/arrow/pull/46509#discussion_r2103328816
##########
cpp/cmake_modules/ThirdpartyToolchain.cmake:
##########
@@ -4845,6 +4845,15 @@ macro(build_opentelemetry)
version)
set(OPENTELEMETRY_BUILD_BYPRODUCTS)
set(OPENTELEMETRY_LIBRARIES)
+ set(OPENTELEMETRY_CXX_FLAGS "${EP_CXX_FLAGS}")
+ # GH-46508: Supress warnings that won't be demoted by -Wno-error in recent
Clang.
+ if((CMAKE_CXX_COMPILER_ID STREQUAL "Clang" AND CMAKE_CXX_COMPILER_VERSION
+ VERSION_GREATER_EQUAL
"19.1.0")
+ OR (CMAKE_CXX_COMPILER_ID STREQUAL "AppleClang" AND
CMAKE_CXX_COMPILER_VERSION
+ VERSION_GREATER_EQUAL
"17.0.0"))
+ string(APPEND OPENTELEMETRY_CXX_FLAGS
+ " -Wno-error=missing-template-arg-list-after-template-kw")
Review Comment:
> I think that we can suppress this too.
@kou Do you happen to know how to suppress this one? I did some search but
couldn't find en effective way to do it.
> How about asking OpenTelemetry C++ developers at
[open-telemetry/opentelemetry-cpp/discussions](https://github.com/open-telemetry/opentelemetry-cpp/discussions)
?
Yeah, I'll try to look into it for some more time. If it doesn't work out,
I'll ask for help from opentelemetry community.
Thanks for the suggestion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
