zeroshade commented on code in PR #2825:
URL: https://github.com/apache/arrow-adbc/pull/2825#discussion_r2114166882
##########
go/adbc/utils/utils.go:
##########
@@ -73,3 +81,50 @@ func removeFieldMetadata(field *arrow.Field) arrow.Field {
Metadata: arrow.Metadata{},
}
}
+
+func SetErrorOnSpan(span trace.Span, err error) bool {
+ if err != nil {
+ span.RecordError(err)
+ if adbcError, ok := err.(adbc.Error); ok {
+
span.SetAttributes(attribute.String(TraceAttributeErrorType,
adbcError.Code.String()))
+ }
+ span.SetStatus(codes.Error, err.Error())
+ return true
+ }
+ return false
+}
+
+func TraceSpan(
+ ctx context.Context,
+ tracing adbc.OTelTracing,
+ spanName string,
+ execFunc func(ctx context.Context, span trace.Span) error,
+ opts ...trace.SpanStartOption,
+) error {
Review Comment:
yea, I'd prefer we avoid the wrapping and delegate. At worst we could have a
utility like such:
```go
func finishSpan(s trace.Span, err *error) {
if !SetSpanOnError(s, *err) {
// there's gotta be a better way than this....
span.SetStatus(codes.Ok, codes.Ok.String())
}
s.End()
}
func (...) SomeMethod(ctx context.Context, ....) (err error) {
ctx, span := startSpan(ctx, spanName, opts...)
defer finishSpan(span, &err)
...
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
