lidavidm commented on code in PR #2825:
URL: https://github.com/apache/arrow-adbc/pull/2825#discussion_r2115226610
##########
go/adbc/driver/internal/driverbase/connection.go:
##########
@@ -183,28 +188,34 @@ func (base *ConnectionImplBase) GetInfo(ctx
context.Context, infoCodes []adbc.In
} else {
strInfoBldr.AppendNull()
}
+ span.SetAttributes(attribute.String(code.String(), v))
Review Comment:
Does setting this on the span actually make any sense?
##########
go/adbc/driver/internal/driverbase/database.go:
##########
@@ -33,7 +33,7 @@ import (
"go.opentelemetry.io/otel/exporters/stdout/stdouttrace"
"go.opentelemetry.io/otel/sdk/resource"
sdktrace "go.opentelemetry.io/otel/sdk/trace"
- semconv "go.opentelemetry.io/otel/semconv/v1.26.0"
+ semconv "go.opentelemetry.io/otel/semconv/v1.30.0"
Review Comment:
Do we need to `go mod tidy`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
