birschick-bq commented on code in PR #2825:
URL: https://github.com/apache/arrow-adbc/pull/2825#discussion_r2114942734
##########
go/adbc/utils/utils.go:
##########
@@ -73,3 +81,50 @@ func removeFieldMetadata(field *arrow.Field) arrow.Field {
Metadata: arrow.Metadata{},
}
}
+
+func SetErrorOnSpan(span trace.Span, err error) bool {
+ if err != nil {
+ span.RecordError(err)
+ if adbcError, ok := err.(adbc.Error); ok {
+
span.SetAttributes(attribute.String(TraceAttributeErrorType,
adbcError.Code.String()))
+ }
+ span.SetStatus(codes.Error, err.Error())
+ return true
+ }
+ return false
+}
+
+func TraceSpan(
+ ctx context.Context,
+ tracing adbc.OTelTracing,
+ spanName string,
+ execFunc func(ctx context.Context, span trace.Span) error,
+ opts ...trace.SpanStartOption,
+) error {
Review Comment:
I think I've implemented what you're looking for. Let me know if it is
satisfactory.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
