birschick-bq commented on code in PR #2825:
URL: https://github.com/apache/arrow-adbc/pull/2825#discussion_r2116285067
##########
go/adbc/driver/internal/driverbase/connection.go:
##########
@@ -183,28 +188,34 @@ func (base *ConnectionImplBase) GetInfo(ctx
context.Context, infoCodes []adbc.In
} else {
strInfoBldr.AppendNull()
}
+ span.SetAttributes(attribute.String(code.String(), v))
Review Comment:
I expect these metrics to be fairly useful for confirming versions and other
attributes of the client/server interaction.
Could we improve on the key name for the attribute? Should they be two
separate attributes - i.e., name and value?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
