birschick-bq commented on code in PR #2825:
URL: https://github.com/apache/arrow-adbc/pull/2825#discussion_r2116643026
##########
go/adbc/utils/utils.go:
##########
@@ -73,3 +81,28 @@ func removeFieldMetadata(field *arrow.Field) arrow.Field {
Metadata: arrow.Metadata{},
}
}
+
Review Comment:
Moved functions to `internal/shared_utils.go` (and added docstrings). This
means I had to remove instrumentation of `QueryContext` in
`sqldriver/driver.go` - but I think each driver can instrument their own
`ExecuteQuery` functions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
