raulcd commented on code in PR #46922: URL: https://github.com/apache/arrow/pull/46922#discussion_r2174510624
########## cpp/src/arrow/dataset/CMakeLists.txt: ########## @@ -207,8 +207,8 @@ if(ARROW_PARQUET) endif() if(ARROW_BUILD_BENCHMARKS) - add_arrow_benchmark(file_benchmark PREFIX "arrow-dataset") - add_arrow_benchmark(scanner_benchmark PREFIX "arrow-dataset") + add_arrow_compute_benchmark(file_benchmark PREFIX "arrow-dataset") + add_arrow_compute_benchmark(scanner_benchmark PREFIX "arrow-dataset") Review Comment: should a name with something like `add_arrow_register_kernels_benchmark` or something like this work better? I could create a function just for dataset `add_arrow_dataset_benchmark` but that would just be a wrapper -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
