raulcd commented on code in PR #46922:
URL: https://github.com/apache/arrow/pull/46922#discussion_r2174678325
##########
cpp/src/arrow/acero/CMakeLists.txt:
##########
@@ -129,6 +129,10 @@ if(ARROW_TESTING)
if(ARROW_WITH_OPENTELEMETRY)
target_link_libraries(arrow_acero_testing PRIVATE
${ARROW_OPENTELEMETRY_LIBS})
endif()
+ # arrow_compute_testing will register the kernels for Gtest. In order to
register the kernels
+ # for Google benchmark we use a custom main function used on
add_arrow_compute_benchmark.
+ set(ARROW_ACERO_BENCHMARKS_TEST_LINK_LIBS
+ ${ARROW_ACERO_TEST_LINK_LIBS} arrow_acero_testing
arrow_compute_core_testing)
Review Comment:
It seems `ARROW_TESTING` is a dependency for `ARROW_BUILD_BENCHMARKS`, we
can use `ARROW_BUILD_BENCHMARKS` and `ARROW_BUILD_TESTS` independently but if
any of those are used the arrow_testing libraries are built.
https://github.com/apache/arrow/blob/587b3fcad5ae4524411714c80a1479ff9a435508/cpp/cmake_modules/DefineOptions.cmake#L220-L240
Thanks for raising this concerns, I am learning a bunch of things I didn't
know :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
