scovich commented on code in PR #7843:
URL: https://github.com/apache/arrow-rs/pull/7843#discussion_r2180081731
##########
parquet-variant/src/builder.rs:
##########
@@ -698,6 +734,15 @@ impl<'a, 'b> ObjectBuilder<'a, 'b> {
///
/// This consumes self and writes the object to the parent buffer.
pub fn finish(mut self) -> Result<(), ArrowError> {
Review Comment:
Interesting! The compiler is normally willing to end the lifetime of the
orphaned `outer_list` just before the `builder.finish` call, but providing an
`impl Drop` somehow force-extends the lifetime?
##########
parquet-variant/src/builder.rs:
##########
@@ -1452,6 +1510,9 @@ mod tests {
"Invalid argument error: Duplicate field keys detected: [x]"
);
+ inner_list.finish();
+ outer_list.finish();
+
Review Comment:
Seems like the test is still broken/useless, if it lacks any checking to
verify the builder actually produced what it was asked to build?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
