viirya commented on code in PR #7843:
URL: https://github.com/apache/arrow-rs/pull/7843#discussion_r2180430057
##########
parquet-variant/src/builder.rs:
##########
@@ -1452,6 +1510,9 @@ mod tests {
"Invalid argument error: Duplicate field keys detected: [x]"
);
+ inner_list.finish();
+ outer_list.finish();
+
Review Comment:
Looks like the test just wants to test field validation for object builders,
one failure case, one success case. It doesn't care about what it actually
builds.
I said "bug" doesn't mean that the test is useless but it lacks the `finish`
calls making it looks not following the insert - finish pattern that is the
what the issue proposed to worry about.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
