viirya commented on code in PR #7843:
URL: https://github.com/apache/arrow-rs/pull/7843#discussion_r2180414161
##########
parquet-variant/src/builder.rs:
##########
@@ -698,6 +734,15 @@ impl<'a, 'b> ObjectBuilder<'a, 'b> {
///
/// This consumes self and writes the object to the parent buffer.
pub fn finish(mut self) -> Result<(), ArrowError> {
Review Comment:
> The compiler is normally willing to end the lifetime of the orphaned
outer_list just before the builder.finish call
No, `outer_list`'s lifetime normally will be ended (if no `finish` call)
after the scope as usual. That's why the compiler complains because it borrows
`builder`. So `builder.finish` call cannot be happened before the end of
`outer_list` lifetime.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
