kou commented on PR #49086: URL: https://github.com/apache/arrow/pull/49086#issuecomment-3830990447
Why did you use `DCHECK` instead of `arrow::Status`? We can use `arrow::Status` by changing return type of `Table::Make` to `Result<std::shared_ptr<Table>>` from `std::shared_ptr<Table>`. `DCHECK` is evaluated only with debug build. Is it intentional? > Additionally, I've included a fix for the macOS CI failures caused by the missing [email protected] formula in Homebrew. Could you work on it as a separated task (open a separated issue and PR) instead of mixing this PR? It's not related to this issue. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
