kou commented on code in PR #49086:
URL: https://github.com/apache/arrow/pull/49086#discussion_r2753242143
##########
cpp/src/arrow/acero/hash_aggregate_test.cc:
##########
@@ -273,7 +273,7 @@ Result<Datum> MakeGroupByOutput(const
std::vector<ExecBatch>& output_batches,
sort_keys.emplace_back(static_cast<int>(i));
}
std::shared_ptr<Schema> key_schema = schema(std::move(key_fields));
- std::shared_ptr<Table> key_table = Table::Make(std::move(key_schema),
key_columns);
+ std::shared_ptr<Table> key_table = Table::Make(std::move(key_schema),
key_columns).ValueOrDie();
Review Comment:
Could you use `ARROW_ASSIGN_OR_RAISE()`?
```suggestion
ARROW_ASSIGN_OR_RAISE(std::shared_ptr<Table> key_table,
Table::Make(std::move(key_schema), key_columns));
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
