pitrou commented on PR #49086: URL: https://github.com/apache/arrow/pull/49086#issuecomment-3841583288
> The issue was raised because there are code paths (like in some tests) where null columns could reach **SimpleTable** constructor, causing crashes. Are these code paths in the Arrow C++ codebase? If so, they should be fixed. > Should we close this as "won't fix" and instead add documentation that callers must validate? Well, unless the docstring for an API states that a pointer is optional, it should always be non-null. This is a common convention in C and C++ codebases, I don't think it's worth mentioning it in each and every docstring. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
