AliRana30 commented on PR #49086:
URL: https://github.com/apache/arrow/pull/49086#issuecomment-3841531134
Post this comment on the PR:
Thank you all for the feedback! I see there are different perspectives on
the best approach:
@pitrou - You mentioned "You're not supposed to pass a null pointer here." I
agree that ideally callers should validate inputs. The issue was raised because
there are code paths (like in some tests) where null columns could reach
**SimpleTable** constructor, causing crashes. Should we close this as "won't
fix" and instead add documentation that callers must validate?
@wgtmac - Your deprecation path suggestion makes sense to avoid breaking
changes. Would this be the preferred approach if we do decide to add validation?
@HuaHuaY - Noted on using std::any_of for cleaner null checking. I can apply
that if we proceed with validation.
Question for team: Should I:
1.Close this PR (accept null inputs are caller responsibility + add docs)
OR
2.Implement @wgtmac's deprecation path
&
3.Keep current approach with std::any_of improvement
I found it(the null pointer deference one) as an issue but I will do as you
all will say ):
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
