AliRana30 commented on PR #49086: URL: https://github.com/apache/arrow/pull/49086#issuecomment-3831214230
Hi @kou, Thank you for the feedback! **### Regarding Table::Make and DCHECK:** You are absolutely right. I have refactored Table::Make (and Table::MakeEmpty) to return Result<std::shared_ptr<Table>> instead of std::shared_ptr<Table>. I have also replaced the DCHECK statements with explicit Status::Invalid returns to ensure validation occurs in both debug and release builds. I’ve updated all call sites across the codebase to handle the new Result type, typically using ARROW_ASSIGN_OR_RAISE or .ValueOrDie() in tests. **### Regarding the macOS CI fix**: I apologize for the oversight in mixing these changes. I have removed the pkg-config related fix from this PR and will submit it as a separate issue and PR as requested to keep this refactor focused. Please let me know if there are any other areas that need adjustments! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
