EmilyMatt commented on code in PR #9700:
URL: https://github.com/apache/arrow-rs/pull/9700#discussion_r3077192773
##########
parquet/src/data_type.rs:
##########
@@ -1071,9 +1081,8 @@ pub(crate) mod private {
Ok(num_values)
}
- #[inline]
- fn dict_encoding_size(&self) -> (usize, usize) {
- (std::mem::size_of::<u32>(), self.len())
+ fn dict_encoding_size(&self) -> usize {
+ 4 + self.len()
}
Review Comment:
Use size_of perhaps?
##########
parquet/src/data_type.rs:
##########
@@ -803,6 +801,10 @@ pub(crate) mod private {
Ok(values_read)
}
+ fn dict_encoding_size(&self) -> usize {
Review Comment:
Magic?
##########
parquet/src/data_type.rs:
##########
@@ -984,6 +990,10 @@ pub(crate) mod private {
Ok(num_values)
}
+ fn dict_encoding_size(&self) -> usize {
+ 12
Review Comment:
Magic?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
