mzabaluev commented on code in PR #9700:
URL: https://github.com/apache/arrow-rs/pull/9700#discussion_r3078242239
##########
parquet/src/data_type.rs:
##########
@@ -803,6 +801,10 @@ pub(crate) mod private {
Ok(values_read)
}
+ fn dict_encoding_size(&self) -> usize {
Review Comment:
Hmm, it's not only that using `size_of` would be dubious, the encoding
actually uses one _bit_ per value, so this method is a leaky abstraction. I'll
see about reworking it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
