mzabaluev commented on code in PR #9700:
URL: https://github.com/apache/arrow-rs/pull/9700#discussion_r3078224462
##########
parquet/src/data_type.rs:
##########
@@ -984,6 +990,10 @@ pub(crate) mod private {
Ok(num_values)
}
+ fn dict_encoding_size(&self) -> usize {
+ 12
Review Comment:
This is a type that encodes to 96 bits. The compound Rust type is
furthermore not declared with a repr that nails down its in-memory size (the
compiler might decide to align such small arrays to 16 bytes one day and jack
up the size accordingly, for example) so I'd argue using `size_of` would not be
squeaky-clean here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
