EmilyMatt commented on code in PR #9700:
URL: https://github.com/apache/arrow-rs/pull/9700#discussion_r3078233417
##########
parquet/src/data_type.rs:
##########
@@ -984,6 +990,10 @@ pub(crate) mod private {
Ok(num_values)
}
+ fn dict_encoding_size(&self) -> usize {
+ 12
Review Comment:
I understand, so a const would be enough^
##########
parquet/src/data_type.rs:
##########
@@ -984,6 +990,10 @@ pub(crate) mod private {
Ok(num_values)
}
+ fn dict_encoding_size(&self) -> usize {
+ 12
Review Comment:
I understand, so a const would be enough, just not a magic number.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
