Taepper commented on code in PR #46926:
URL: https://github.com/apache/arrow/pull/46926#discussion_r3403570493
##########
cpp/src/arrow/compute/api_vector.h:
##########
@@ -102,10 +103,15 @@ class ARROW_EXPORT ArraySortOptions : public
FunctionOptions {
NullPlacement null_placement;
};
+ARROW_SUPPRESS_DEPRECATION_WARNING
Review Comment:
I was able to move it inside but needed to manually add this block:
```
ARROW_SUPPRESS_DEPRECATION_WARNING
SortOptions(SortOptions&&) = default;
SortOptions(const SortOptions&) = default;
SortOptions& operator=(SortOptions&&) = default;
SortOptions& operator=(const SortOptions&) = default;
ARROW_UNSUPPRESS_DEPRECATION_WARNING
```
because the `null_placement` member is deprecated
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
