Taepper commented on code in PR #46926:
URL: https://github.com/apache/arrow/pull/46926#discussion_r3403822236
##########
python/pyarrow/_compute.pyx:
##########
@@ -2499,17 +2527,26 @@ class RankOptions(_RankOptions):
number of distinct values in the input.
"""
- def __init__(self, sort_keys="ascending", *, null_placement="at_end",
tiebreaker="first"):
+ def __init__(self, sort_keys="ascending", *, null_placement=None,
tiebreaker="first"):
self._set_options(sort_keys, null_placement, tiebreaker)
Review Comment:
Good question, probably yes, I added the same warning from `__init__` in
`SortOptions`. Is there more to do for the deprecation?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
