Taepper commented on code in PR #46926:
URL: https://github.com/apache/arrow/pull/46926#discussion_r3404346046
##########
cpp/src/arrow/compute/api_vector.cc:
##########
@@ -138,8 +140,7 @@ static auto kArraySortOptionsType =
GetFunctionOptionsType<ArraySortOptions>(
DataMember("order", &ArraySortOptions::order),
DataMember("null_placement", &ArraySortOptions::null_placement));
static auto kSortOptionsType = GetFunctionOptionsType<SortOptions>(
- DataMember("sort_keys", &SortOptions::sort_keys),
- DataMember("null_placement", &SortOptions::null_placement));
+ CoercedDataMember("sort_keys", &SortOptions::sort_keys,
&SortOptions::GetSortKeys));
Review Comment:
Very good point. Additional tests added in
`eea17e5aa3a7e42ef923dec20567d6d600096ff3` did indeed fail. They were fixed
with `80bf5d29ea5b591e74fb19994e7c6dbebb10dbb2`. Is this the correct approach
and is there something I might have missed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
