Taepper commented on PR #46926:
URL: https://github.com/apache/arrow/pull/46926#issuecomment-4693132174
Thank you for the review. I was not sure regarding the introduction of
`std::span` usage, which I find very succinct.
For example, also this `std::ranges::` based for-loop replacement has now
been detected by my local `clangd`:
```
for (uint64_t& reverse_out_iter :
std::ranges::reverse_view(output.non_null_like_range))
{...}
```
instead of
```
for (auto reverse_out_iter = output.non_null_like_range.rbegin();
reverse_out_iter != output.non_null_like_range.rend();
reverse_out_iter++) {
```
Feel free to let me know if these code-style preferences are not wanted
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
