pitrou commented on code in PR #46926:
URL: https://github.com/apache/arrow/pull/46926#discussion_r3413569245
##########
cpp/src/arrow/compute/api_vector.cc:
##########
@@ -138,8 +140,7 @@ static auto kArraySortOptionsType =
GetFunctionOptionsType<ArraySortOptions>(
DataMember("order", &ArraySortOptions::order),
DataMember("null_placement", &ArraySortOptions::null_placement));
static auto kSortOptionsType = GetFunctionOptionsType<SortOptions>(
- DataMember("sort_keys", &SortOptions::sort_keys),
- DataMember("null_placement", &SortOptions::null_placement));
+ CoercedDataMember("sort_keys", &SortOptions::sort_keys,
&SortOptions::GetSortKeys));
Review Comment:
That looks like it indeed. I don't think this is exercised much apart from
unit tests TBH.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
