alamb commented on a change in pull request #971:
URL: https://github.com/apache/arrow-datafusion/pull/971#discussion_r705589989
##########
File path: datafusion/src/logical_plan/expr.rs
##########
@@ -934,6 +934,19 @@ impl Not for Expr {
}
}
+impl std::fmt::Display for Expr {
+ fn fmt(&self, f: &mut std::fmt::Formatter) -> std::fmt::Result {
+ match self {
+ Expr::BinaryExpr {
+ ref left,
+ ref right,
+ ref op,
+ } => write!(f, "{} {} {}", left, op, right),
+ _ => write!(f, "{}", ""),
Review comment:
Ideally, this code would cover all the variants of `Expr` -- however,
that doesn't have to be done in one PR.
How about as a potential interim solution we could do something like the
following and use the debug display until someone has time to add a better
display implementation?
```suggestion
_ => write!(f, "{:?}", self),
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
