matthewmturner commented on a change in pull request #971:
URL: https://github.com/apache/arrow-datafusion/pull/971#discussion_r706254389
##########
File path: datafusion/src/sql/planner.rs
##########
@@ -2343,8 +2347,8 @@ mod tests {
GROUP BY first_name
HAVING MAX(age) > 100 AND MIN(id - 2) < 50";
let expected = "Projection: #person.first_name, #MAX(person.age)\
- \n Filter: #MAX(person.age) Gt Int64(100) And
#MIN(person.id Minus Int64(2)) Lt Int64(50)\
- \n Aggregate: groupBy=[[#person.first_name]],
aggr=[[MAX(#person.age), MIN(#person.id Minus Int64(2))]]\
+ \n Filter: #MAX(person.age) > Int64(100) AND
#MIN(person.id Minus Int64(2)) < Int64(50)\
Review comment:
@alamb Im a bit confused. The minus operator seems to be formatted
differently depending on the part of the plan its in - is that expected? The
test passes right now but i had to use `Minus` in the `Filter` section and `-`
in the `Aggregate` section.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
