Dandandan commented on a change in pull request #971:
URL: https://github.com/apache/arrow-datafusion/pull/971#discussion_r709428410
##########
File path: datafusion/src/physical_plan/aggregates.rs
##########
@@ -64,7 +64,7 @@ pub enum AggregateFunction {
impl fmt::Display for AggregateFunction {
fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result {
// uppercase of the debug.
- write!(f, "{}", format!("{:?}", self).to_uppercase())
+ write!(f, "{}", self)
Review comment:
Isn't this doing infinite recursion, as it will try to use the same
method to display `self`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
