alamb commented on a change in pull request #971:
URL: https://github.com/apache/arrow-datafusion/pull/971#discussion_r706364143



##########
File path: datafusion/src/sql/planner.rs
##########
@@ -2343,8 +2347,8 @@ mod tests {
                    GROUP BY first_name
                    HAVING MAX(age) > 100 AND MIN(id - 2) < 50";
         let expected = "Projection: #person.first_name, #MAX(person.age)\
-                        \n  Filter: #MAX(person.age) Gt Int64(100) And 
#MIN(person.id Minus Int64(2)) Lt Int64(50)\
-                        \n    Aggregate: groupBy=[[#person.first_name]], 
aggr=[[MAX(#person.age), MIN(#person.id Minus Int64(2))]]\
+                        \n  Filter: #MAX(person.age) > Int64(100) AND 
#MIN(person.id Minus Int64(2)) < Int64(50)\

Review comment:
       One difference is that `MIN` is a aggregate function which is a 
different type of Expr -- perhaps it formats its arguments using `{:?}`
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to