matthewmturner commented on a change in pull request #971:
URL: https://github.com/apache/arrow-datafusion/pull/971#discussion_r709296900
##########
File path: datafusion/src/physical_plan/aggregates.rs
##########
@@ -64,7 +64,7 @@ pub enum AggregateFunction {
impl fmt::Display for AggregateFunction {
fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result {
// uppercase of the debug.
- write!(f, "{}", format!("{:?}", self).to_uppercase())
+ write!(f, "{}", self)
Review comment:
@alamb FYI after making this update I get a stack overflow error when
running the test
`select_aggregate_with_group_by_with_having_using_derived_column_aggreagate_not_in_select`.
I think i saw on some other issues/PRs a stack related issue, and im not sure
if it could be related to this, but wanted to run it by you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
