pitrou commented on a change in pull request #11147:
URL: https://github.com/apache/arrow/pull/11147#discussion_r712115997
##########
File path: python/pyarrow/_compute.pyx
##########
@@ -690,99 +677,96 @@ class CastOptions(_CastOptions):
cdef class _ElementWiseAggregateOptions(FunctionOptions):
- def _set_options(self, bint skip_nulls):
+ def _set_options(self, skip_nulls):
self.wrapped.reset(new CElementWiseAggregateOptions(skip_nulls))
class ElementWiseAggregateOptions(_ElementWiseAggregateOptions):
- def __init__(self, bint skip_nulls=True):
+ def __init__(self, skip_nulls=True):
Review comment:
Should this one become keyword-only? `ElementWiseAggregateOptions(true)`
isn't very explicit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
