pitrou commented on a change in pull request #11147:
URL: https://github.com/apache/arrow/pull/11147#discussion_r712113784
##########
File path: python/pyarrow/includes/libarrow.pxd
##########
@@ -2069,10 +2076,15 @@ cdef extern from "arrow/compute/api.h" namespace
"arrow::compute" nogil:
cdef cppclass CMakeStructOptions \
"arrow::compute::MakeStructOptions"(CFunctionOptions):
- CMakeStructOptions(vector[c_string] field_names)
+ CMakeStructOptions(vector[c_string] n,
+ vector[c_bool] r,
+ vector[shared_ptr[const CKeyValueMetadata]] m)
+ CMakeStructOptions(vector[c_string] n)
vector[c_string] field_names
+ vector[c_bool] field_nullability
+ vector[shared_ptr[const CKeyValueMetadata]] field_metadata
- ctypedef enum CSortOrder" arrow::compute::SortOrder":
+ cdef enum CSortOrder" arrow::compute::SortOrder":
Review comment:
It seems these `cdef` changes may have broken AppVeyor. Can you take a
look?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
