9prady9 commented on a change in pull request #11674:
URL: https://github.com/apache/arrow/pull/11674#discussion_r748997607
##########
File path: cpp/src/arrow/util/bitmap_ops.cc
##########
@@ -311,39 +345,49 @@ Result<std::shared_ptr<Buffer>> BitmapAnd(MemoryPool*
pool, const uint8_t* left,
int64_t left_offset, const uint8_t*
right,
int64_t right_offset, int64_t length,
int64_t out_offset) {
+ // TODO(pradeep) Figure out the return type for this version of BitmapOps
+ int64_t out_pop_count = 0;
return BitmapOp<std::bit_and>(pool, left, left_offset, right, right_offset,
length,
- out_offset);
+ out_offset, &out_pop_count);
Review comment:
In the function that is returning output value, should I make it pair of
int64_t and Array ? what is usually done in arrow ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
