9prady9 commented on a change in pull request #11674:
URL: https://github.com/apache/arrow/pull/11674#discussion_r748998763



##########
File path: cpp/src/arrow/util/bit_util_benchmark.cc
##########
@@ -159,9 +159,12 @@ static void BenchmarkAndImpl(benchmark::State& state, 
DoAnd&& do_and) {
 
 static void BenchmarkBitmapAnd(benchmark::State& state) {
   BenchmarkAndImpl(state, [](const internal::Bitmap(&bitmaps)[2], 
internal::Bitmap* out) {
+    int64_t outPopCount = 0;
     internal::BitmapAnd(bitmaps[0].buffer()->data(), bitmaps[0].offset(),
                         bitmaps[1].buffer()->data(), bitmaps[1].offset(),
-                        bitmaps[0].length(), 0, out->buffer()->mutable_data());
+                        bitmaps[0].length(), 0, out->buffer()->mutable_data(),
+                        &outPopCount);
+    benchmark::DoNotOptimize(outPopCount);

Review comment:
       Done, will push all updates in one go.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to